Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MSVC runtime check failure #5557

Merged
merged 2 commits into from
Jun 2, 2022
Merged

Fix MSVC runtime check failure #5557

merged 2 commits into from
Jun 2, 2022

Conversation

danieltabacaru
Copy link
Collaborator

@danieltabacaru danieltabacaru commented Jun 2, 2022 •
edited
Loading

What, How & Why?

Fix a segfault around changeset encoding when compiling sync by MSVC 2022.

☑️ ToDos

  • 📝 Changelog update
  • [ ] 🚦 Tests (or not relevant)
  • [ ] C-API, if public C++ API changed.

@cla-bot cla-bot bot added the cla: yes label Jun 2, 2022
nirinchev
nirinchev approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@nirinchev nirinchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the stack corruption error that MSVC reports. Our tests also pass with this change, so LGTM. Still, will be a good idea to get thumbs up from someone on Core.

@danieltabacaru danieltabacaru merged commit f8f6b37 into master Jun 2, 2022
@danieltabacaru danieltabacaru deleted the dt/fix_changeset_encoder_runtime_error branch June 2, 2022 14:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jedelbo jedelbo jedelbo approved these changes

@nirinchev nirinchev nirinchev approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danieltabacaru @jedelbo @nirinchev